[coreboot-gerrit] Change in coreboot[master]: nb/intel/pineview: Use the correct address for the RCVEN strobe

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/28230


Change subject: nb/intel/pineview: Use the correct address for the RCVEN strobe
......................................................................

nb/intel/pineview: Use the correct address for the RCVEN strobe

When doing the receive enable training, the final mapping of the ranks is
already done, so we can be sure that that address 0x00000000 there will always
be a rank.

Change-Id: I7ac017a8816fc9a47cef0695826a1c32f699f6f8
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/northbridge/intel/pineview/raminit.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/28230/1

diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c
index f1e0767..a050e06 100644
--- a/src/northbridge/intel/pineview/raminit.c
+++ b/src/northbridge/intel/pineview/raminit.c
@@ -1875,7 +1875,9 @@
 	u8 minbytelanecoarse = 0xff;
 	u8 bytelaneoffset;
 	u8 maxbytelane = 8;
-	u32 strobeaddr = (rank_is_populated(s->dimms, 0, 0)) ? 0 : 2*128*1024*1024;
+	/* Since dra/drb is already set up we know that at address 0x00000000
+	   we will always find the first available rank */
+	u32 strobeaddr = 0;
 	u32 dqshighaddr;
 
 	MCHBAR8(0x5d8) = MCHBAR8(0x5d8) & ~0xc;

-- 
To view, visit https://review.coreboot.org/28230
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ac017a8816fc9a47cef0695826a1c32f699f6f8
Gerrit-Change-Number: 28230
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180820/1826dc4f/attachment-0001.html>