[coreboot-gerrit] Change in coreboot[master]: nb/intel/pineview: Use i2c block read to fetch SPD

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Aug 20 11:32:59 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28229 )

Change subject: nb/intel/pineview: Use i2c block read to fetch SPD
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/28229/1/src/northbridge/intel/pineview/raminit.c
File src/northbridge/intel/pineview/raminit.c:

https://review.coreboot.org/#/c/28229/1/src/northbridge/intel/pineview/raminit.c@277
PS1, Line 277: 		if (i2c_block_read(s->spd_map[i], 0, 64, s->dimms[i].spd_data) != 64)
line over 80 characters



-- 
To view, visit https://review.coreboot.org/28229
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic23f39f1017010c89795e626f6a6f918f8bda17a
Gerrit-Change-Number: 28229
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 20 Aug 2018 09:32:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180820/b2881662/attachment.html>


More information about the coreboot-gerrit mailing list