<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28230">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/pineview: Use the correct address for the RCVEN strobe<br><br>When doing the receive enable training, the final mapping of the ranks is<br>already done, so we can be sure that that address 0x00000000 there will always<br>be a rank.<br><br>Change-Id: I7ac017a8816fc9a47cef0695826a1c32f699f6f8<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/northbridge/intel/pineview/raminit.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/28230/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c</span><br><span>index f1e0767..a050e06 100644</span><br><span>--- a/src/northbridge/intel/pineview/raminit.c</span><br><span>+++ b/src/northbridge/intel/pineview/raminit.c</span><br><span>@@ -1875,7 +1875,9 @@</span><br><span>     u8 minbytelanecoarse = 0xff;</span><br><span>         u8 bytelaneoffset;</span><br><span>   u8 maxbytelane = 8;</span><br><span style="color: hsl(0, 100%, 40%);">-     u32 strobeaddr = (rank_is_populated(s->dimms, 0, 0)) ? 0 : 2*128*1024*1024;</span><br><span style="color: hsl(120, 100%, 40%);">+        /* Since dra/drb is already set up we know that at address 0x00000000</span><br><span style="color: hsl(120, 100%, 40%);">+    we will always find the first available rank */</span><br><span style="color: hsl(120, 100%, 40%);">+    u32 strobeaddr = 0;</span><br><span>  u32 dqshighaddr;</span><br><span> </span><br><span>         MCHBAR8(0x5d8) = MCHBAR8(0x5d8) & ~0xc;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28230">change 28230</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28230"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7ac017a8816fc9a47cef0695826a1c32f699f6f8 </div>
<div style="display:none"> Gerrit-Change-Number: 28230 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>