[coreboot-gerrit] Change in coreboot[master]: soc/intel/basecode: Add support for updating microcode in the field

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27369 )

Change subject: soc/intel/basecode: Add support for updating microcode in the field
......................................................................


Patch Set 17:

(4 comments)

https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_update/ucode_update.c
File src/soc/intel/common/basecode/fw_update/ucode_update.c:

https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_update/ucode_update.c@39
PS17, Line 39: 	die("Failed to restart\n");
Prefer using '"%s...", __func__' to using 'restart', this function's name, in a string


https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_update/ucode_update.c@74
PS17, Line 74: 		printk (BIOS_ERR, "Slot ucode not found!\n");
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_update/ucode_update.c@84
PS17, Line 84: 		printk (BIOS_ERR, "Staging area could not be initialized!\n");
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_update/ucode_update.c@104
PS17, Line 104: 		printk (BIOS_ERR, "Staging area could not be mapped!\n");
space prohibited between function name and open parenthesis '('



-- 
To view, visit https://review.coreboot.org/27369
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab6ba36a2eb587f331fe522c778e2c430c8eb655
Gerrit-Change-Number: 27369
Gerrit-PatchSet: 17
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Dhaval Sharma <dhaval.v.sharma at intel.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 16 Aug 2018 15:48:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180816/b650b172/attachment.html>