<p><a href="https://review.coreboot.org/27369">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_update/ucode_update.c">File src/soc/intel/common/basecode/fw_update/ucode_update.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_update/ucode_update.c@39">Patch Set #17, Line 39:</a> <code style="font-family:monospace,monospace">    die("Failed to restart\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer using '"%s...", __func__' to using 'restart', this function's name, in a string</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_update/ucode_update.c@74">Patch Set #17, Line 74:</a> <code style="font-family:monospace,monospace">          printk (BIOS_ERR, "Slot ucode not found!\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_update/ucode_update.c@84">Patch Set #17, Line 84:</a> <code style="font-family:monospace,monospace">             printk (BIOS_ERR, "Staging area could not be initialized!\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27369/17/src/soc/intel/common/basecode/fw_update/ucode_update.c@104">Patch Set #17, Line 104:</a> <code style="font-family:monospace,monospace">          printk (BIOS_ERR, "Staging area could not be mapped!\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited between function name and open parenthesis '('</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27369">change 27369</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27369"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iab6ba36a2eb587f331fe522c778e2c430c8eb655 </div>
<div style="display:none"> Gerrit-Change-Number: 27369 </div>
<div style="display:none"> Gerrit-PatchSet: 17 </div>
<div style="display:none"> Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Dhaval Sharma <dhaval.v.sharma@intel.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 16 Aug 2018 15:48:34 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>