[coreboot-gerrit] Change in coreboot[master]: google/grunt: Update TP/TS/H1 i2c timings

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28119 )

Change subject: google/grunt: Update TP/TS/H1 i2c timings
......................................................................

google/grunt: Update TP/TS/H1 i2c timings

After adjustment on Careena EVT
TP: 400.0 KHz
TS: 396.8 KHz
H1: 396.8 KHz

BUG=b:112663934,b:112664258
BRANCH=master
TEST=emerge-grunt coreboot
     measure by scope
Change-Id: I9eeaf9290d95969a283f14618878e28faf0ea46f
Signed-off-by: Kevin Chiu <Kevin.Chiu at quantatw.com>
Reviewed-on: https://review.coreboot.org/28119
Reviewed-by: Martin Roth <martinroth at google.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/mainboard/google/kahlee/variants/careena/devicetree.cb
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved



diff --git a/src/mainboard/google/kahlee/variants/careena/devicetree.cb b/src/mainboard/google/kahlee/variants/careena/devicetree.cb
index 61476a2..513bd4e 100644
--- a/src/mainboard/google/kahlee/variants/careena/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/careena/devicetree.cb
@@ -32,22 +32,22 @@
 	register "i2c[1]" = "{
 		.early_init = 1,
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 84,
+		.rise_time_ns = 45,
 		.fall_time_ns = 4,
 	}"
 
 	# Enable I2C2 for trackpad, pen at 400kHz
 	register "i2c[2]" = "{
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 117,
-		.fall_time_ns = 113,
+		.rise_time_ns = 67,
+		.fall_time_ns = 55,
 	}"
 
 	# Enable I2C3 for touchscreen at 400kHz
 	register "i2c[3]" = "{
 		.speed = I2C_SPEED_FAST,
-		.rise_time_ns = 82,
-		.fall_time_ns = 67,
+		.rise_time_ns = 22,
+		.fall_time_ns = 19,
 	}"
 
 	device cpu_cluster 0 on

-- 
To view, visit https://review.coreboot.org/28119
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9eeaf9290d95969a283f14618878e28faf0ea46f
Gerrit-Change-Number: 28119
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu <Kevin.Chiu at quantatw.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu at quanta.corp-partner.google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180817/0f277c6b/attachment.html>