[coreboot-gerrit] Change in coreboot[master]: mainboard/google/nocturne: turn off cams in D3

[Lance Zhao (Code Review)]

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/28073 )

Change subject: mainboard/google/nocturne: turn off cams in D3
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/28073/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/28073/1//COMMIT_MSG@9
PS1, Line 9: This means that we're
           : telling the OS that the cams need power in both D0 and D3 (and not the
           : intermediate states)
I don't think that's how OSPM to determine the power needed or not in D3 state. The power resource list in _PR3 will be turned off if OSPM decided to enter D3hot state(Or D3 cold depends on how OS decided in _OSC).

My understanding is delete _PR3 will make power resources in FRPR kept in On state but not turned off.



-- 
To view, visit https://review.coreboot.org/28073
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id52c2499c3b7577f03395cc9ca2460f25b80e13f
Gerrit-Change-Number: 28073
Gerrit-PatchSet: 1
Gerrit-Owner: Matt Delco <delco at chromium.org>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Matt Delco <delco at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Lance Zhao <lance.zhao at gmail.com>
Gerrit-Comment-Date: Mon, 13 Aug 2018 23:40:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180813/8cf47204/attachment.html>