[coreboot-gerrit] Change in coreboot[master]: mainboard/google/nocturne: turn off cams in D3
Matt Delco (Code Review)
gerrit at coreboot.org
Tue Aug 14 01:25:47 CEST 2018
Matt Delco has uploaded this change for review. ( https://review.coreboot.org/28073
Change subject: mainboard/google/nocturne: turn off cams in D3
......................................................................
mainboard/google/nocturne: turn off cams in D3
Power resources are cited for _PR0 and _PR3. This means that we're
telling the OS that the cams need power in both D0 and D3 (and not the
intermediate states). This change deletes _PR3 so that power isn't
supplied during D3 and the camera light doesn't stay on continuously.
Change-Id: Id52c2499c3b7577f03395cc9ca2460f25b80e13f
Signed-off-by: Matt Delco <delco at chromium.org>
---
M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl
M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl
2 files changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/28073/1
diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl
index ec4430d..1688356 100644
--- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl
+++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl
@@ -71,7 +71,6 @@
})
Name (_PR0, Package () { FCPR })
- Name (_PR3, Package () { FCPR })
/* Port0 of CAM0 is connected to port0 of CIO2 device */
Name (_DSD, Package () {
@@ -134,7 +133,6 @@
Name (_DEP, Package () { CAM0 })
Name (_PR0, Package () { FCPR })
- Name (_PR3, Package () { FCPR })
Name (_DSD, Package ()
{
diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl
index 19146dc..3f6fe8d 100644
--- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl
+++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl
@@ -70,7 +70,6 @@
})
Name (_PR0, Package () { RCPR })
- Name (_PR3, Package () { RCPR })
/* Port0 of CAM1 is connected to port1 of CIO2 device */
Name (_DSD, Package () {
@@ -138,7 +137,6 @@
Name (_DEP, Package() { CAM1 })
Name (_PR0, Package () { RCPR })
- Name (_PR3, Package () { RCPR })
Name (_DSD, Package () {
ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
@@ -168,7 +166,6 @@
Name (_DEP, Package () { CAM1 })
Name (_PR0, Package () { RCPR })
- Name (_PR3, Package () { RCPR })
Name (_DSD, Package ()
{
--
To view, visit https://review.coreboot.org/28073
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id52c2499c3b7577f03395cc9ca2460f25b80e13f
Gerrit-Change-Number: 28073
Gerrit-PatchSet: 1
Gerrit-Owner: Matt Delco <delco at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180813/8c300a91/attachment-0001.html>
More information about the coreboot-gerrit
mailing list