<p>Matt Delco has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28073">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/nocturne: turn off cams in D3<br><br>Power resources are cited for _PR0 and _PR3.  This means that we're<br>telling the OS that the cams need power in both D0 and D3 (and not the<br>intermediate states).  This change deletes _PR3 so that power isn't<br>supplied during D3 and the camera light doesn't stay on continuously.<br><br>Change-Id: Id52c2499c3b7577f03395cc9ca2460f25b80e13f<br>Signed-off-by: Matt Delco <delco@chromium.org><br>---<br>M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl<br>M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl<br>2 files changed, 0 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/28073/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl</span><br><span>index ec4430d..1688356 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl</span><br><span>@@ -71,7 +71,6 @@</span><br><span>           })</span><br><span> </span><br><span>               Name (_PR0, Package () { FCPR })</span><br><span style="color: hsl(0, 100%, 40%);">-                Name (_PR3, Package () { FCPR })</span><br><span> </span><br><span>                 /* Port0 of CAM0 is connected to port0 of CIO2 device */</span><br><span>             Name (_DSD, Package () {</span><br><span>@@ -134,7 +133,6 @@</span><br><span>               Name (_DEP, Package () { CAM0 })</span><br><span> </span><br><span>                 Name (_PR0, Package () { FCPR })</span><br><span style="color: hsl(0, 100%, 40%);">-                Name (_PR3, Package () { FCPR })</span><br><span> </span><br><span>                 Name (_DSD, Package ()</span><br><span>               {</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl</span><br><span>index 19146dc..3f6fe8d 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl</span><br><span>@@ -70,7 +70,6 @@</span><br><span>           })</span><br><span> </span><br><span>               Name (_PR0, Package () { RCPR })</span><br><span style="color: hsl(0, 100%, 40%);">-                Name (_PR3, Package () { RCPR })</span><br><span> </span><br><span>                 /* Port0 of CAM1 is connected to port1 of CIO2 device */</span><br><span>             Name (_DSD, Package () {</span><br><span>@@ -138,7 +137,6 @@</span><br><span>               Name (_DEP, Package() { CAM1 })</span><br><span> </span><br><span>          Name (_PR0, Package () { RCPR })</span><br><span style="color: hsl(0, 100%, 40%);">-                Name (_PR3, Package () { RCPR })</span><br><span> </span><br><span>                 Name (_DSD, Package () {</span><br><span>                     ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span>@@ -168,7 +166,6 @@</span><br><span>             Name (_DEP, Package () { CAM1 })</span><br><span> </span><br><span>                 Name (_PR0, Package () { RCPR })</span><br><span style="color: hsl(0, 100%, 40%);">-                Name (_PR3, Package () { RCPR })</span><br><span> </span><br><span>                 Name (_DSD, Package ()</span><br><span>               {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28073">change 28073</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28073"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id52c2499c3b7577f03395cc9ca2460f25b80e13f </div>
<div style="display:none"> Gerrit-Change-Number: 28073 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt Delco <delco@chromium.org> </div>