[coreboot-gerrit] Change in coreboot[master]: mainboard/google/nocturne: turn off cams in D3

[Matt Delco (Code Review)]

Matt Delco has posted comments on this change. ( https://review.coreboot.org/28073 )

Change subject: mainboard/google/nocturne: turn off cams in D3
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/28073/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/28073/1//COMMIT_MSG@9
PS1, Line 9: This means that we're
           : telling the OS that the cams need power in both D0 and D3 (and not the
           : intermediate states)
> I don't think that's how OSPM to determine the power needed or not in D3 state. […]
My understanding is that the _PR3 means the devices will have power in D3hot.

Prior to this change the device would have power in D0 and D3hot, but not D1, D2, or D3cold.  After this change only D0 will have power.  All the cam devices I can find outside of coreboot have a _PR0 but not a _PR3.  It seems more appropriate to remove the _PR3 than add a _PR2 (and probably also a "Name(_S0W, 4)" to make Windows think it's okay to transition the device to D3cold).



-- 
To view, visit https://review.coreboot.org/28073
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id52c2499c3b7577f03395cc9ca2460f25b80e13f
Gerrit-Change-Number: 28073
Gerrit-PatchSet: 1
Gerrit-Owner: Matt Delco <delco at chromium.org>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Matt Delco <delco at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Lance Zhao <lance.zhao at gmail.com>
Gerrit-Comment-Date: Tue, 14 Aug 2018 04:54:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180814/969c0d62/attachment.html>