[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8183: Move common flow of romstage from mainboard to SoC

Tristan Hsieh (Code Review) gerrit at coreboot.org
Fri Aug 10 03:58:18 CEST 2018


Tristan Hsieh has uploaded this change for review. ( https://review.coreboot.org/27998


Change subject: mediatek/mt8183: Move common flow of romstage from mainboard to SoC
......................................................................

mediatek/mt8183: Move common flow of romstage from mainboard to SoC

Main flow of romstage should be pretty much the same among all MT8183
mainboards. Move it into SoC code such that any new mainboards do not
need to duplicate it.

BUG=b:80501386
TEST=Boots correctly on Kukui

Change-Id: I6c9e056e464b88dc53f63c0d0388133ea8e6f59c
Signed-off-by: Tristan Shieh <tristan.shieh at mediatek.com>
---
M src/mainboard/google/kukui/Makefile.inc
M src/soc/mediatek/mt8183/Makefile.inc
R src/soc/mediatek/mt8183/romstage.c
3 files changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/27998/1

diff --git a/src/mainboard/google/kukui/Makefile.inc b/src/mainboard/google/kukui/Makefile.inc
index 290be4c..ee2ac12 100644
--- a/src/mainboard/google/kukui/Makefile.inc
+++ b/src/mainboard/google/kukui/Makefile.inc
@@ -7,7 +7,6 @@
 
 romstage-y += chromeos.c
 romstage-y += memlayout.ld
-romstage-y += romstage.c
 
 ramstage-y += chromeos.c
 ramstage-y += mainboard.c
diff --git a/src/soc/mediatek/mt8183/Makefile.inc b/src/soc/mediatek/mt8183/Makefile.inc
index bd0e54f..6c9ef13 100644
--- a/src/soc/mediatek/mt8183/Makefile.inc
+++ b/src/soc/mediatek/mt8183/Makefile.inc
@@ -23,6 +23,7 @@
 romstage-y += emi.c
 romstage-y += ../common/gpio.c gpio.c
 romstage-y += ../common/mmu_operations.c mmu_operations.c
+romstage-y += romstage.c
 romstage-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c
 romstage-y += ../common/timer.c
 romstage-$(CONFIG_DRIVERS_UART) += ../common/uart.c
diff --git a/src/mainboard/google/kukui/romstage.c b/src/soc/mediatek/mt8183/romstage.c
similarity index 100%
rename from src/mainboard/google/kukui/romstage.c
rename to src/soc/mediatek/mt8183/romstage.c

-- 
To view, visit https://review.coreboot.org/27998
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c9e056e464b88dc53f63c0d0388133ea8e6f59c
Gerrit-Change-Number: 27998
Gerrit-PatchSet: 1
Gerrit-Owner: Tristan Hsieh <tristan.shieh at mediatek.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180810/5e2070d9/attachment-0001.html>


More information about the coreboot-gerrit mailing list