<p>Tristan Hsieh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27998">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mediatek/mt8183: Move common flow of romstage from mainboard to SoC<br><br>Main flow of romstage should be pretty much the same among all MT8183<br>mainboards. Move it into SoC code such that any new mainboards do not<br>need to duplicate it.<br><br>BUG=b:80501386<br>TEST=Boots correctly on Kukui<br><br>Change-Id: I6c9e056e464b88dc53f63c0d0388133ea8e6f59c<br>Signed-off-by: Tristan Shieh <tristan.shieh@mediatek.com><br>---<br>M src/mainboard/google/kukui/Makefile.inc<br>M src/soc/mediatek/mt8183/Makefile.inc<br>R src/soc/mediatek/mt8183/romstage.c<br>3 files changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/27998/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kukui/Makefile.inc b/src/mainboard/google/kukui/Makefile.inc</span><br><span>index 290be4c..ee2ac12 100644</span><br><span>--- a/src/mainboard/google/kukui/Makefile.inc</span><br><span>+++ b/src/mainboard/google/kukui/Makefile.inc</span><br><span>@@ -7,7 +7,6 @@</span><br><span> </span><br><span> romstage-y += chromeos.c</span><br><span> romstage-y += memlayout.ld</span><br><span style="color: hsl(0, 100%, 40%);">-romstage-y += romstage.c</span><br><span> </span><br><span> ramstage-y += chromeos.c</span><br><span> ramstage-y += mainboard.c</span><br><span>diff --git a/src/soc/mediatek/mt8183/Makefile.inc b/src/soc/mediatek/mt8183/Makefile.inc</span><br><span>index bd0e54f..6c9ef13 100644</span><br><span>--- a/src/soc/mediatek/mt8183/Makefile.inc</span><br><span>+++ b/src/soc/mediatek/mt8183/Makefile.inc</span><br><span>@@ -23,6 +23,7 @@</span><br><span> romstage-y += emi.c</span><br><span> romstage-y += ../common/gpio.c gpio.c</span><br><span> romstage-y += ../common/mmu_operations.c mmu_operations.c</span><br><span style="color: hsl(120, 100%, 40%);">+romstage-y += romstage.c</span><br><span> romstage-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c</span><br><span> romstage-y += ../common/timer.c</span><br><span> romstage-$(CONFIG_DRIVERS_UART) += ../common/uart.c</span><br><span>diff --git a/src/mainboard/google/kukui/romstage.c b/src/soc/mediatek/mt8183/romstage.c</span><br><span>similarity index 100%</span><br><span>rename from src/mainboard/google/kukui/romstage.c</span><br><span>rename to src/soc/mediatek/mt8183/romstage.c</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27998">change 27998</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27998"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6c9e056e464b88dc53f63c0d0388133ea8e6f59c </div>
<div style="display:none"> Gerrit-Change-Number: 27998 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Tristan Hsieh <tristan.shieh@mediatek.com> </div>