[coreboot-gerrit] Change in coreboot[master]: mb/biostar/am1ml: Use common pnp_{enter, exit} functions

[Elyes HAOUAS (Code Review)]

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/27934


Change subject: mb/biostar/am1ml: Use common pnp_{enter,exit} functions
......................................................................

mb/biostar/am1ml: Use common pnp_{enter,exit} functions

Change-Id: I73b8811767da1b0356cffb6a26553400b2f10841
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/mainboard/biostar/am1ml/romstage.c
1 file changed, 28 insertions(+), 50 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/27934/1

diff --git a/src/mainboard/biostar/am1ml/romstage.c b/src/mainboard/biostar/am1ml/romstage.c
index 7caa4dc..2512e51 100644
--- a/src/mainboard/biostar/am1ml/romstage.c
+++ b/src/mainboard/biostar/am1ml/romstage.c
@@ -34,62 +34,40 @@
 #define MMIO_NON_POSTED_END	0xfedfffff
 #define SB_MMIO_MISC32(x)	*(volatile u32 *)(AMD_SB_ACPI_MMIO_ADDR + 0xE00 + (x))
 
-
-static void it_sio_write(pnp_devfn_t dev, u8 reg, u8 value)
-{
-	pnp_set_logical_device(dev);
-	pnp_write_config(dev, reg, value);
-}
-
-static void ite_enter_conf(pnp_devfn_t dev)
-{
-	u16 port = dev >> 8;
-
-	outb(0x87, port);
-	outb(0x01, port);
-	outb(0x55, port);
-	outb((port == 0x4e) ? 0xaa : 0x55, port);
-}
-
-static void ite_exit_conf(pnp_devfn_t dev)
-{
-	it_sio_write(dev, ITE_CONFIG_REG_CC, 0x02);
-}
-
 static void ite_evc_conf(pnp_devfn_t dev)
 {
-	ite_enter_conf(dev);
-	it_sio_write(dev, 0xf1 , 0x40 );
-	it_sio_write(dev, 0xf4 , 0x80 );
-	it_sio_write(dev, 0xf5 , 0x00 );
-	it_sio_write(dev, 0xf6 , 0xf0 );
-	it_sio_write(dev, 0xf9 , 0x48 );
-	it_sio_write(dev, 0xfa , 0x00 );
-	it_sio_write(dev, 0xfb , 0x00 );
-	ite_exit_conf(dev);
+	pnp_enter_conf_state(dev);
+	ite_sio_write(dev, 0xf1 , 0x40 );
+	ite_sio_write(dev, 0xf4 , 0x80 );
+	ite_sio_write(dev, 0xf5 , 0x00 );
+	ite_sio_write(dev, 0xf6 , 0xf0 );
+	ite_sio_write(dev, 0xf9 , 0x48 );
+	ite_sio_write(dev, 0xfa , 0x00 );
+	ite_sio_write(dev, 0xfb , 0x00 );
+	pnp_exit_conf_state(dev);
 }
 
 static void ite_gpio_conf(pnp_devfn_t dev)
 {
-	ite_enter_conf (dev);
-	it_sio_write (dev, 0x25 , 0x80 );
-	it_sio_write (dev, 0x26 , 0x07 );
-	it_sio_write (dev, 0x28 , 0x81 );
-	it_sio_write (dev, 0x2c , 0x06 );
-	it_sio_write (dev, 0x72 , 0x00 );
-	it_sio_write (dev, 0x73 , 0x00 );
-	it_sio_write (dev, 0xb3 , 0x01 );
-	it_sio_write (dev, 0xb8 , 0x00 );
-	it_sio_write (dev, 0xc0 , 0x00 );
-	it_sio_write (dev, 0xc3 , 0x00 );
-	it_sio_write (dev, 0xc8 , 0x00 );
-	it_sio_write (dev, 0xc9 , 0x07 );
-	it_sio_write (dev, 0xcb , 0x01 );
-	it_sio_write (dev, 0xf0 , 0x10 );
-	it_sio_write (dev, 0xf4 , 0x27 );
-	it_sio_write (dev, 0xf8 , 0x20 );
-	it_sio_write (dev, 0xf9 , 0x01 );
-	ite_exit_conf (dev);
+	pnp_enter_conf_state(dev);
+	ite_sio_write (dev, 0x25 , 0x80 );
+	ite_sio_write (dev, 0x26 , 0x07 );
+	ite_sio_write (dev, 0x28 , 0x81 );
+	ite_sio_write (dev, 0x2c , 0x06 );
+	ite_sio_write (dev, 0x72 , 0x00 );
+	ite_sio_write (dev, 0x73 , 0x00 );
+	ite_sio_write (dev, 0xb3 , 0x01 );
+	ite_sio_write (dev, 0xb8 , 0x00 );
+	ite_sio_write (dev, 0xc0 , 0x00 );
+	ite_sio_write (dev, 0xc3 , 0x00 );
+	ite_sio_write (dev, 0xc8 , 0x00 );
+	ite_sio_write (dev, 0xc9 , 0x07 );
+	ite_sio_write (dev, 0xcb , 0x01 );
+	ite_sio_write (dev, 0xf0 , 0x10 );
+	ite_sio_write (dev, 0xf4 , 0x27 );
+	ite_sio_write (dev, 0xf8 , 0x20 );
+	ite_sio_write (dev, 0xf9 , 0x01 );
+	pnp_exit_conf_state(dev);
 }
 
 void board_BeforeAgesa(struct sysinfo *cb)

-- 
To view, visit https://review.coreboot.org/27934
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73b8811767da1b0356cffb6a26553400b2f10841
Gerrit-Change-Number: 27934
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180807/80224bc7/attachment.html>