[coreboot-gerrit] Change in coreboot[master]: mb/biostar/am1ml: Use common pnp_{enter, exit} functions

Tue Aug 7 19:14:05 CEST 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27934 )

Change subject: mb/biostar/am1ml: Use common pnp_{enter,exit} functions
......................................................................

Patch Set 1:

(65 comments)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c
File src/mainboard/biostar/am1ml/romstage.c:

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@40
PS1, Line 40: 	ite_sio_write(dev, 0xf1 , 0x40 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@40
PS1, Line 40: 	ite_sio_write(dev, 0xf1 , 0x40 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@41
PS1, Line 41: 	ite_sio_write(dev, 0xf4 , 0x80 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@41
PS1, Line 41: 	ite_sio_write(dev, 0xf4 , 0x80 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@42
PS1, Line 42: 	ite_sio_write(dev, 0xf5 , 0x00 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@42
PS1, Line 42: 	ite_sio_write(dev, 0xf5 , 0x00 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@43
PS1, Line 43: 	ite_sio_write(dev, 0xf6 , 0xf0 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@43
PS1, Line 43: 	ite_sio_write(dev, 0xf6 , 0xf0 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@44
PS1, Line 44: 	ite_sio_write(dev, 0xf9 , 0x48 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@44
PS1, Line 44: 	ite_sio_write(dev, 0xf9 , 0x48 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@45
PS1, Line 45: 	ite_sio_write(dev, 0xfa , 0x00 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@45
PS1, Line 45: 	ite_sio_write(dev, 0xfa , 0x00 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@46
PS1, Line 46: 	ite_sio_write(dev, 0xfb , 0x00 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@46
PS1, Line 46: 	ite_sio_write(dev, 0xfb , 0x00 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@53
PS1, Line 53: 	ite_sio_write (dev, 0x25 , 0x80 );
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@53
PS1, Line 53: 	ite_sio_write (dev, 0x25 , 0x80 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@53
PS1, Line 53: 	ite_sio_write (dev, 0x25 , 0x80 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@54
PS1, Line 54: 	ite_sio_write (dev, 0x26 , 0x07 );
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@54
PS1, Line 54: 	ite_sio_write (dev, 0x26 , 0x07 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@54
PS1, Line 54: 	ite_sio_write (dev, 0x26 , 0x07 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@55
PS1, Line 55: 	ite_sio_write (dev, 0x28 , 0x81 );
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@55
PS1, Line 55: 	ite_sio_write (dev, 0x28 , 0x81 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@55
PS1, Line 55: 	ite_sio_write (dev, 0x28 , 0x81 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@56
PS1, Line 56: 	ite_sio_write (dev, 0x2c , 0x06 );
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@56
PS1, Line 56: 	ite_sio_write (dev, 0x2c , 0x06 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@56
PS1, Line 56: 	ite_sio_write (dev, 0x2c , 0x06 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@57
PS1, Line 57: 	ite_sio_write (dev, 0x72 , 0x00 );
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@57
PS1, Line 57: 	ite_sio_write (dev, 0x72 , 0x00 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@57
PS1, Line 57: 	ite_sio_write (dev, 0x72 , 0x00 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@58
PS1, Line 58: 	ite_sio_write (dev, 0x73 , 0x00 );
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@58
PS1, Line 58: 	ite_sio_write (dev, 0x73 , 0x00 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@58
PS1, Line 58: 	ite_sio_write (dev, 0x73 , 0x00 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@59
PS1, Line 59: 	ite_sio_write (dev, 0xb3 , 0x01 );
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@59
PS1, Line 59: 	ite_sio_write (dev, 0xb3 , 0x01 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@59
PS1, Line 59: 	ite_sio_write (dev, 0xb3 , 0x01 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@60
PS1, Line 60: 	ite_sio_write (dev, 0xb8 , 0x00 );
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@60
PS1, Line 60: 	ite_sio_write (dev, 0xb8 , 0x00 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@60
PS1, Line 60: 	ite_sio_write (dev, 0xb8 , 0x00 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@61
PS1, Line 61: 	ite_sio_write (dev, 0xc0 , 0x00 );
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@61
PS1, Line 61: 	ite_sio_write (dev, 0xc0 , 0x00 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@61
PS1, Line 61: 	ite_sio_write (dev, 0xc0 , 0x00 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@62
PS1, Line 62: 	ite_sio_write (dev, 0xc3 , 0x00 );
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@62
PS1, Line 62: 	ite_sio_write (dev, 0xc3 , 0x00 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@62
PS1, Line 62: 	ite_sio_write (dev, 0xc3 , 0x00 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@63
PS1, Line 63: 	ite_sio_write (dev, 0xc8 , 0x00 );
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@63
PS1, Line 63: 	ite_sio_write (dev, 0xc8 , 0x00 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@63
PS1, Line 63: 	ite_sio_write (dev, 0xc8 , 0x00 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@64
PS1, Line 64: 	ite_sio_write (dev, 0xc9 , 0x07 );
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@64
PS1, Line 64: 	ite_sio_write (dev, 0xc9 , 0x07 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@64
PS1, Line 64: 	ite_sio_write (dev, 0xc9 , 0x07 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@65
PS1, Line 65: 	ite_sio_write (dev, 0xcb , 0x01 );
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@65
PS1, Line 65: 	ite_sio_write (dev, 0xcb , 0x01 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@65
PS1, Line 65: 	ite_sio_write (dev, 0xcb , 0x01 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@66
PS1, Line 66: 	ite_sio_write (dev, 0xf0 , 0x10 );
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@66
PS1, Line 66: 	ite_sio_write (dev, 0xf0 , 0x10 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@66
PS1, Line 66: 	ite_sio_write (dev, 0xf0 , 0x10 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@67
PS1, Line 67: 	ite_sio_write (dev, 0xf4 , 0x27 );
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@67
PS1, Line 67: 	ite_sio_write (dev, 0xf4 , 0x27 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@67
PS1, Line 67: 	ite_sio_write (dev, 0xf4 , 0x27 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@68
PS1, Line 68: 	ite_sio_write (dev, 0xf8 , 0x20 );
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@68
PS1, Line 68: 	ite_sio_write (dev, 0xf8 , 0x20 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@68
PS1, Line 68: 	ite_sio_write (dev, 0xf8 , 0x20 );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@69
PS1, Line 69: 	ite_sio_write (dev, 0xf9 , 0x01 );
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@69
PS1, Line 69: 	ite_sio_write (dev, 0xf9 , 0x01 );
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstage.c@69
PS1, Line 69: 	ite_sio_write (dev, 0xf9 , 0x01 );
space prohibited before that close parenthesis ')'

-- 
To view, visit https://review.coreboot.org/27934
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73b8811767da1b0356cffb6a26553400b2f10841
Gerrit-Change-Number: 27934
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 07 Aug 2018 17:14:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180807/ac253cf6/attachment.html>