[coreboot-gerrit] Change in coreboot[master]: mb/intel/cannonlake_rvp/devicetree.cb: Remove misleading comments
Arthur Heymans (Code Review)
gerrit at coreboot.org
Tue Aug 7 16:04:01 CEST 2018
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/27927
Change subject: mb/intel/cannonlake_rvp/devicetree.cb: Remove misleading comments
......................................................................
mb/intel/cannonlake_rvp/devicetree.cb: Remove misleading comments
The devicetree is not run through a C pre-processor, so remove it.
Change-Id: I161be45b2035f3a8724bf3217260e7571c429da8
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/27927/1
diff --git a/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb b/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb
index 4c62800..6f1b6eb 100644
--- a/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb
+++ b/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb
@@ -95,7 +95,6 @@
device pci 15.1 on end # I2C #1
device pci 15.2 off end # I2C #2
device pci 15.3 on
- #if IS_ENABLED(CONFIG_INCLUDE_SND_MAX98373_NHLT)
chip drivers/i2c/max98373
register "vmon_slot_no" = "4"
register "imon_slot_no" = "5"
@@ -112,7 +111,6 @@
register "name" = ""MAXL""
device i2c 32 on end
end
- #elif IS_ENABLED(CONFIG_INCLUDE_SND_MAX98357_DA7219_NHLT)
chip drivers/i2c/da7219
register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A20)"
register "btn_cfg" = "50"
@@ -130,7 +128,6 @@
register "mic_amp_in_sel" = ""diff""
device i2c 1a on end
end
- #endif
end # I2C #3
device pci 16.0 on end # Management Engine Interface 1
device pci 16.1 off end # Management Engine Interface 2
@@ -167,14 +164,12 @@
end # LPC Interface
device pci 1f.1 on end # P2SB
device pci 1f.2 on end # Power Management Controller
- #if IS_ENABLED(CONFIG_INCLUDE_SND_MAX98357_DA7219_NHLT)
device pci 1f.3 on
chip drivers/generic/max98357a
register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D16)"
register "sdmode_delay" = "5"
device generic 0 on end
end
- end # Intel HDA
#endif
device pci 1f.4 on end # SMBus
device pci 1f.5 on end # PCH SPI
--
To view, visit https://review.coreboot.org/27927
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I161be45b2035f3a8724bf3217260e7571c429da8
Gerrit-Change-Number: 27927
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180807/da890047/attachment-0001.html>
More information about the coreboot-gerrit
mailing list