[coreboot-gerrit] Change in coreboot[master]: mb/intel/cannonlake_rvp/devicetree.cb: Remove misleading comments

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27927 )

Change subject: mb/intel/cannonlake_rvp/devicetree.cb: Remove misleading comments
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/27927/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/27927/1//COMMIT_MSG@7
PS1, Line 7: .cb
no suffix needed


https://review.coreboot.org/#/c/27927/1//COMMIT_MSG@7
PS1, Line 7: misleading comments
they are not supposed to be comments. maybe rather `Remove spurious
CPP directives`.


https://review.coreboot.org/#/c/27927/1//COMMIT_MSG@9
PS1, Line 9: The devicetree is not run through a C pre-processor, so remove it.
Hmmmm, I guess the extra chip entries do matter for I2C.
Because that bus isn't probed... I guess the drivers add
spurious ACPI code currently. That should be fixed if it's
the case.



-- 
To view, visit https://review.coreboot.org/27927
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I161be45b2035f3a8724bf3217260e7571c429da8
Gerrit-Change-Number: 27927
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Tue, 07 Aug 2018 14:12:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180807/8f32d1f1/attachment.html>