<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27927">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/intel/cannonlake_rvp/devicetree.cb: Remove misleading comments<br><br>The devicetree is not run through a C pre-processor, so remove it.<br><br>Change-Id: I161be45b2035f3a8724bf3217260e7571c429da8<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb<br>1 file changed, 0 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/27927/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb b/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb</span><br><span>index 4c62800..6f1b6eb 100644</span><br><span>--- a/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb</span><br><span>+++ b/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb</span><br><span>@@ -95,7 +95,6 @@</span><br><span>              device pci 15.1 on  end # I2C #1</span><br><span>             device pci 15.2 off end # I2C #2</span><br><span>             device pci 15.3 on</span><br><span style="color: hsl(0, 100%, 40%);">-                      #if IS_ENABLED(CONFIG_INCLUDE_SND_MAX98373_NHLT)</span><br><span>                     chip drivers/i2c/max98373</span><br><span>                            register "vmon_slot_no" = "4"</span><br><span>                            register "imon_slot_no" = "5"</span><br><span>@@ -112,7 +111,6 @@</span><br><span>                              register "name" = ""MAXL""</span><br><span>                             device i2c 32 on end</span><br><span>                         end</span><br><span style="color: hsl(0, 100%, 40%);">-                     #elif IS_ENABLED(CONFIG_INCLUDE_SND_MAX98357_DA7219_NHLT)</span><br><span>                    chip drivers/i2c/da7219</span><br><span>                              register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A20)"</span><br><span>                           register "btn_cfg" = "50"</span><br><span>@@ -130,7 +128,6 @@</span><br><span>                          register "mic_amp_in_sel" = ""diff""</span><br><span>                           device i2c 1a on end</span><br><span>                         end</span><br><span style="color: hsl(0, 100%, 40%);">-                     #endif</span><br><span>               end   # I2C #3</span><br><span>               device pci 16.0 on  end # Management Engine Interface 1</span><br><span>              device pci 16.1 off end # Management Engine Interface 2</span><br><span>@@ -167,14 +164,12 @@</span><br><span>              end # LPC Interface</span><br><span>          device pci 1f.1 on  end # P2SB</span><br><span>               device pci 1f.2 on  end # Power Management Controller</span><br><span style="color: hsl(0, 100%, 40%);">-           #if IS_ENABLED(CONFIG_INCLUDE_SND_MAX98357_DA7219_NHLT)</span><br><span>              device pci 1f.3 on</span><br><span>                   chip drivers/generic/max98357a</span><br><span>                               register "sdmode_gpio" =  "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D16)"</span><br><span>                                register "sdmode_delay" = "5"</span><br><span>                            device generic 0 on end</span><br><span>                      end</span><br><span style="color: hsl(0, 100%, 40%);">-             end # Intel HDA</span><br><span>              #endif</span><br><span>               device pci 1f.4 on  end # SMBus</span><br><span>              device pci 1f.5 on  end # PCH SPI</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27927">change 27927</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27927"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I161be45b2035f3a8724bf3217260e7571c429da8 </div>
<div style="display:none"> Gerrit-Change-Number: 27927 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>