[coreboot-gerrit] Change in coreboot[master]: lib/bootmem.c:Remove unused setting of variable "begin"
Richard Spiegel (Code Review)
gerrit at coreboot.org
Tue Aug 7 00:27:31 CEST 2018
Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/27886
Change subject: lib/bootmem.c:Remove unused setting of variable "begin"
......................................................................
lib/bootmem.c:Remove unused setting of variable "begin"
The variable "begin" is extracted from the structure, but 4 lines below
it's overwritten with "end - size". This causes a static build scan error
that should be fixed. Remove the initial assignment of variable "begin".
BUG=b:112253891
TEST=Build and boot grunt.
Change-Id: I0a265747e61289f045c5cac09e40478bd31e16fc
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/lib/bootmem.c
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/27886/1
diff --git a/src/lib/bootmem.c b/src/lib/bootmem.c
index 66d4592..38fdb1b 100644
--- a/src/lib/bootmem.c
+++ b/src/lib/bootmem.c
@@ -278,7 +278,6 @@
return NULL;
/* region now points to the highest usable region for the given size. */
- begin = range_entry_base(region);
end = range_entry_end(region);
if (end > max_addr)
end = max_addr;
--
To view, visit https://review.coreboot.org/27886
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a265747e61289f045c5cac09e40478bd31e16fc
Gerrit-Change-Number: 27886
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180806/ca50df0f/attachment.html>
More information about the coreboot-gerrit
mailing list