[coreboot-gerrit] Change in coreboot[master]: Makefile: Enable DELETE_ON_ERROR for all targets

Raul Rangel (Code Review) gerrit at coreboot.org
Tue Aug 7 00:14:05 CEST 2018


Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/27885


Change subject: Makefile: Enable DELETE_ON_ERROR for all targets
......................................................................

Makefile: Enable DELETE_ON_ERROR for all targets

If a target is interrupted in the middle of writing an output file, the
file could be left in a corrupt state. A subsequent make invocation will
see the file as up to date and can cause very confusing errors.

BUG=b:112267918
TEST=Made a target fail before completion and verified make deleted the
output file.

Change-Id: I865827ea769b4dffa638d4324fc7284f6cb2ddc0
Signed-off-by: Raul E Rangel <rrangel at chromium.org>
---
M Makefile
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/27885/1

diff --git a/Makefile b/Makefile
index 4aa179d..1d4a488 100644
--- a/Makefile
+++ b/Makefile
@@ -174,6 +174,7 @@
 
 # must come rather early
 .SECONDEXPANSION:
+.DELETE_ON_ERROR:
 
 $(KCONFIG_AUTOHEADER): $(KCONFIG_CONFIG)
 	+$(MAKE) oldconfig

-- 
To view, visit https://review.coreboot.org/27885
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I865827ea769b4dffa638d4324fc7284f6cb2ddc0
Gerrit-Change-Number: 27885
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180806/d3355265/attachment.html>


More information about the coreboot-gerrit mailing list