[coreboot-gerrit] Change in coreboot[master]: cpu/intel/smm: Don't make assumptions on TSEG_SIZE

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27872 )

Change subject: cpu/intel/smm: Don't make assumptions on TSEG_SIZE
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/27872/1/src/cpu/intel/smm/gen1/smmrelocate.c
File src/cpu/intel/smm/gen1/smmrelocate.c:

https://review.coreboot.org/#/c/27872/1/src/cpu/intel/smm/gen1/smmrelocate.c@161
PS1, Line 161: 		ASSERT(CONFIG_IED_REGION_SIZE > params->smram_size);
Comparisons should place the constant on the right side of the test


https://review.coreboot.org/#/c/27872/1/src/cpu/intel/smm/gen1/smmrelocate.c@169
PS1, Line 169: 		ASSERT(CONFIG_SMM_RESERVED_SIZE > params->smram_size);
Comparisons should place the constant on the right side of the test



-- 
To view, visit https://review.coreboot.org/27872
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aadc6f0459a8035864dcf02b0a07e00b284fe2a
Gerrit-Change-Number: 27872
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 06 Aug 2018 14:13:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180806/89f2f45a/attachment.html>