<p><a href="https://review.coreboot.org/27872">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27872/1/src/cpu/intel/smm/gen1/smmrelocate.c">File src/cpu/intel/smm/gen1/smmrelocate.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27872/1/src/cpu/intel/smm/gen1/smmrelocate.c@161">Patch Set #1, Line 161:</a> <code style="font-family:monospace,monospace">           ASSERT(CONFIG_IED_REGION_SIZE > params->smram_size);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Comparisons should place the constant on the right side of the test</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27872/1/src/cpu/intel/smm/gen1/smmrelocate.c@169">Patch Set #1, Line 169:</a> <code style="font-family:monospace,monospace">                ASSERT(CONFIG_SMM_RESERVED_SIZE > params->smram_size);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Comparisons should place the constant on the right side of the test</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27872">change 27872</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27872"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I1aadc6f0459a8035864dcf02b0a07e00b284fe2a </div>
<div style="display:none"> Gerrit-Change-Number: 27872 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 06 Aug 2018 14:13:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>