[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/rammus: add rammus devicetree.cb

[Zhuohao Lee (Code Review)]

Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/27808 )

Change subject: mb/google/poppy/variants/rammus: add rammus devicetree.cb
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/27808/1/src/mainboard/google/poppy/variants/rammus/devicetree.cb
File src/mainboard/google/poppy/variants/rammus/devicetree.cb:

https://review.coreboot.org/#/c/27808/1/src/mainboard/google/poppy/variants/rammus/devicetree.cb@47
PS1, Line 47: 2
> 0?
Rammus will use SOC SDIO, so we need to enable this.


https://review.coreboot.org/#/c/27808/1/src/mainboard/google/poppy/variants/rammus/devicetree.cb@82
PS1, Line 82: 	#| IccMax         | 4A    | 28A   | 24A   | 24A   |
> This is already being set here: https://review.coreboot. […]
Thanks for point it out. i will remove the IccMax setting.



-- 
To view, visit https://review.coreboot.org/27808
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icabfac04c94b3d480872c243d811509e274ef122
Gerrit-Change-Number: 27808
Gerrit-PatchSet: 1
Gerrit-Owner: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 03 Aug 2018 00:03:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180803/643a8036/attachment.html>