<p><a href="https://review.coreboot.org/27808">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27808/1/src/mainboard/google/poppy/variants/rammus/devicetree.cb">File src/mainboard/google/poppy/variants/rammus/devicetree.cb:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27808/1/src/mainboard/google/poppy/variants/rammus/devicetree.cb@47">Patch Set #1, Line 47:</a> <code style="font-family:monospace,monospace">2</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">0?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Rammus will use SOC SDIO, so we need to enable this.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27808/1/src/mainboard/google/poppy/variants/rammus/devicetree.cb@82">Patch Set #1, Line 82:</a> <code style="font-family:monospace,monospace">     #| IccMax         | 4A    | 28A   | 24A   | 24A   |</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This is already being set here: https://review.coreboot. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks for point it out. i will remove the IccMax setting.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27808">change 27808</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27808"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Icabfac04c94b3d480872c243d811509e274ef122 </div>
<div style="display:none"> Gerrit-Change-Number: 27808 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Zhuohao Lee <zhuohao@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Zhuohao Lee <zhuohao@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 03 Aug 2018 00:03:35 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>