[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/rammus: add rammus devicetree.cb

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27808 )

Change subject: mb/google/poppy/variants/rammus: add rammus devicetree.cb
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/27808/1/src/mainboard/google/poppy/variants/rammus/devicetree.cb
File src/mainboard/google/poppy/variants/rammus/devicetree.cb:

PS1: 
More of a TODO for myself: It would be good to check if poppy and variants can be converted to use override devicetree.


https://review.coreboot.org/#/c/27808/1/src/mainboard/google/poppy/variants/rammus/devicetree.cb@47
PS1, Line 47: 2
0?


https://review.coreboot.org/#/c/27808/1/src/mainboard/google/poppy/variants/rammus/devicetree.cb@82
PS1, Line 82: 	#| IccMax         | 4A    | 28A   | 24A   | 24A   |
This is already being set here: https://review.coreboot.org/c/coreboot/+/27610, so setting of IccMax here is not required.


https://review.coreboot.org/#/c/27808/1/src/mainboard/google/poppy/variants/rammus/devicetree.cb@328
PS1, Line 328: on
off



-- 
To view, visit https://review.coreboot.org/27808
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icabfac04c94b3d480872c243d811509e274ef122
Gerrit-Change-Number: 27808
Gerrit-PatchSet: 1
Gerrit-Owner: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 02 Aug 2018 16:41:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180802/e3950501/attachment.html>