[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Update UPD from device switch

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27766 )

Change subject: soc/intel/cannonlake: Update UPD from device switch
......................................................................


Patch Set 3:

(5 comments)

https://review.coreboot.org/#/c/27766/3/src/soc/intel/cannonlake/chip.c
File src/soc/intel/cannonlake/chip.c:

https://review.coreboot.org/#/c/27766/3/src/soc/intel/cannonlake/chip.c@253
PS3, Line 253: 		params->Usb2AfePredeemp[i] = config->usb2_ports[i].tx_emp_enable;
line over 80 characters


https://review.coreboot.org/#/c/27766/3/src/soc/intel/cannonlake/chip.c@262
PS3, Line 262: 			params->Usb3HsioTxDeEmph[i] = config->usb3_ports[i].tx_de_emp;
line over 80 characters


https://review.coreboot.org/#/c/27766/3/src/soc/intel/cannonlake/chip.c@266
PS3, Line 266: 			params->Usb3HsioTxDownscaleAmp[i] = config->usb3_ports[i].tx_downscale_amp;
line over 80 characters


https://review.coreboot.org/#/c/27766/3/src/soc/intel/cannonlake/chip.c@295
PS3, Line 295: 			params->PchScsEmmcHs400RxStrobeDll1 = config->EmmcHs400RxStrobeDll1;
line over 80 characters


https://review.coreboot.org/#/c/27766/3/src/soc/intel/cannonlake/chip.c@296
PS3, Line 296: 			params->PchScsEmmcHs400TxDataDll = config->EmmcHs400TxDataDll;
line over 80 characters



-- 
To view, visit https://review.coreboot.org/27766
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36cfab03c4613786e5580a039d89007b630adf9
Gerrit-Change-Number: 27766
Gerrit-PatchSet: 3
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 02 Aug 2018 16:26:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180802/ac1d0ea1/attachment.html>