[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge/raminit: Fix PDWN_mode on desktops

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/22260 )

Change subject: nb/intel/sandybridge/raminit: Fix PDWN_mode on desktops
......................................................................


Patch Set 1:

(1 comment)

I'd suggest adding a #define PM_PDWN_Config 0x4cb0 and then using that constant in the code instead of the magic offset

https://review.coreboot.org/#/c/22260/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/22260/1//COMMIT_MSG@11
PS1, Line 11: 2.14.1.
2.17.1 on the datasheet I have



-- 
To view, visit https://review.coreboot.org/22260
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic42f2ff3e719636be67b00fa37155939cd2e17de
Gerrit-Change-Number: 22260
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Comment-Date: Sat, 28 Apr 2018 19:56:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180428/327e13ac/attachment.html>