<p style="white-space: pre-wrap; word-wrap: break-word;">I'd suggest adding a #define PM_PDWN_Config 0x4cb0 and then using that constant in the code instead of the magic offset</p><p><a href="https://review.coreboot.org/22260">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/22260/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22260/1//COMMIT_MSG@11">Patch Set #1, Line 11:</a> <code style="font-family:monospace,monospace">2.14.1.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">2.17.1 on the datasheet I have</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22260">change 22260</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22260"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic42f2ff3e719636be67b00fa37155939cd2e17de </div>
<div style="display:none"> Gerrit-Change-Number: 22260 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 28 Apr 2018 19:56:05 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>