[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Fix for using IDT PMIC

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/25585 )

Change subject: siemens/mc_apl1: Fix for using IDT PMIC
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/25585/1/src/mainboard/siemens/mc_apl1/mainboard.c
File src/mainboard/siemens/mc_apl1/mainboard.c:

https://review.coreboot.org/#/c/25585/1/src/mainboard/siemens/mc_apl1/mainboard.c@146
PS1, Line 146: 			mdelay(1);
is this delay required here? if not, you might be better off by using the stopwatch API from src/include/timer.h: create a stopwatch and use "while (!stopwatch_expired(sw)) ..."



-- 
To view, visit https://review.coreboot.org/25585
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77faf95951d03ac6ce97a6721dba6e8466122a25
Gerrit-Change-Number: 25585
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi at google.com>
Gerrit-Comment-Date: Tue, 10 Apr 2018 13:31:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180410/92ac59d2/attachment.html>