[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Fix for using IDT PMIC

Mario Scheithauer (Code Review) gerrit at coreboot.org
Tue Apr 10 17:26:17 CEST 2018


Hello Werner Zeh, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/25585

to look at the new patch set (#2).

Change subject: siemens/mc_apl1: Fix for using IDT PMIC
......................................................................

siemens/mc_apl1: Fix for using IDT PMIC

Due to an accuracy issue on IMON in the IDT PMIC, the reported system
power consumption was higher than the actual consumption. To prevent
this problem, a logic must be implement in mainboard_init(). This logic
consists of slope and offset as constants for Vcc and Vnn, which needs
to be programmed by coreboot. This fix compensates for the accuracy
issue.

Change-Id: I77faf95951d03ac6ce97a6721dba6e8466122a25
Signed-off-by: Mario Scheithauer <mario.scheithauer at siemens.com>
---
M src/mainboard/siemens/mc_apl1/mainboard.c
1 file changed, 71 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/25585/2
-- 
To view, visit https://review.coreboot.org/25585
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I77faf95951d03ac6ce97a6721dba6e8466122a25
Gerrit-Change-Number: 25585
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180410/50446bcb/attachment.html>


More information about the coreboot-gerrit mailing list