<p><a href="https://review.coreboot.org/25585">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25585/1/src/mainboard/siemens/mc_apl1/mainboard.c">File src/mainboard/siemens/mc_apl1/mainboard.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25585/1/src/mainboard/siemens/mc_apl1/mainboard.c@146">Patch Set #1, Line 146:</a> <code style="font-family:monospace,monospace">                     mdelay(1);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">is this delay required here? if not, you might be better off by using the stopwatch API from src/include/timer.h: create a stopwatch and use "while (!stopwatch_expired(sw)) ..."</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/25585">change 25585</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25585"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I77faf95951d03ac6ce97a6721dba6e8466122a25 </div>
<div style="display:none"> Gerrit-Change-Number: 25585 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Mario Scheithauer <mario.scheithauer@siemens.com> </div>
<div style="display:none"> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 10 Apr 2018 13:31:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>