[coreboot-gerrit] Change in coreboot[master]: util/cbfstool: Add "expand" command to make CBFS span an fmap region

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/21598 )

Change subject: util/cbfstool: Add "expand" command to make CBFS span an fmap region
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/21598/1/util/cbfstool/cbfstool.c
File util/cbfstool/cbfstool.c:

https://review.coreboot.org/#/c/21598/1/util/cbfstool/cbfstool.c@1300
PS1, Line 1300: 			"Expand CBFS to span entire region\n"
> Don't we want to kill two birds with one stone and implement a command that
I considered that, but that quickly devolves in an epic yak shave: We still need to extract the region after we truncate, then pass through whatever else we have in the build system to reassemble the image, yada yada yada...

(or we'd need to find a different place where the truncate operation fits in better in the build system flow)

At that point I thought I'll make this commit do one thing and do it well.



-- 
To view, visit https://review.coreboot.org/21598
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I160c8529ce4bfcc28685166b6d9035ade4f6f1d1
Gerrit-Change-Number: 21598
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 19 Sep 2017 20:00:31 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170919/44b31c1e/attachment.html>