<p>Patrick Georgi <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/21598">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/21598/1/util/cbfstool/cbfstool.c">File util/cbfstool/cbfstool.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21598/1/util/cbfstool/cbfstool.c@1300">Patch Set #1, Line 1300:</a> <code style="font-family:monospace,monospace">                   "Expand CBFS to span entire region\n"</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Don't we want to kill two birds with one stone and implement a command that</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I considered that, but that quickly devolves in an epic yak shave: We still need to extract the region after we truncate, then pass through whatever else we have in the build system to reassemble the image, yada yada yada...</p><p style="white-space: pre-wrap; word-wrap: break-word;">(or we'd need to find a different place where the truncate operation fits in better in the build system flow)</p><p style="white-space: pre-wrap; word-wrap: break-word;">At that point I thought I'll make this commit do one thing and do it well.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/21598">change 21598</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21598"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I160c8529ce4bfcc28685166b6d9035ade4f6f1d1 </div>
<div style="display:none"> Gerrit-Change-Number: 21598 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Caveh Jalali <caveh@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 19 Sep 2017 20:00:31 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>