[coreboot-gerrit] Change in coreboot[master]: util/cbfstool: Add "expand" command to make CBFS span an fmap region

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/21598 )

Change subject: util/cbfstool: Add "expand" command to make CBFS span an fmap region
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/21598/1/util/cbfstool/cbfstool.c
File util/cbfstool/cbfstool.c:

https://review.coreboot.org/#/c/21598/1/util/cbfstool/cbfstool.c@1300
PS1, Line 1300: 			"Expand CBFS to span entire region\n"
Don't we want to kill two birds with one stone and implement a command that can both expand and truncate here? The "parse cbfstool output with sed" solution we currently use to truncate in the ebuild doesn't really inspire that much confidence anyway, I think while we're redoing this anyway we might as well do away with that. (I'd call the command cbfstool truncate then, with behavior similar to the truncate POSIX tool.)



-- 
To view, visit https://review.coreboot.org/21598
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I160c8529ce4bfcc28685166b6d9035ade4f6f1d1
Gerrit-Change-Number: 21598
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 19 Sep 2017 19:49:07 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170919/473733bd/attachment.html>