[coreboot-gerrit] Change in coreboot[master]: device/dram/ddr2: Fix decoding tRR

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21457 )

Change subject: device/dram/ddr2: Fix decoding tRR
......................................................................


Patch Set 1:

(4 comments)

Have you checked any actual SPD value?

https://review.coreboot.org/#/c/21457/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/21457/1//COMMIT_MSG@9
PS1, Line 9: Bit 7 should not be used in computation.
Why? the spec says it should be set?


https://review.coreboot.org/#/c/21457/1/src/device/dram/ddr2.c
File src/device/dram/ddr2.c:

https://review.coreboot.org/#/c/21457/1/src/device/dram/ddr2.c@187
PS1, Line 187: 	case 0:
In my version of the spec this is 0x80.


https://review.coreboot.org/#/c/21457/1/src/device/dram/ddr2.c@189
PS1, Line 189: 	case 1:
0x81


https://review.coreboot.org/#/c/21457/1/src/device/dram/ddr2.c@191
PS1, Line 191: 	case 2:
...



-- 
To view, visit https://review.coreboot.org/21457
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a698ec9c15a2611a34c5965edf93638553775f0
Gerrit-Change-Number: 21457
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Fri, 08 Sep 2017 22:07:48 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170908/7a8cb254/attachment.html>