<p>Nico Huber <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/21457">View Change</a></p><p>Patch set 1:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Have you checked any actual SPD value?</p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/21457/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21457/1//COMMIT_MSG@9">Patch Set #1, Line 9:</a> <code style="font-family:monospace,monospace">Bit 7 should not be used in computation.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why? the spec says it should be set?</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/21457/1/src/device/dram/ddr2.c">File src/device/dram/ddr2.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21457/1/src/device/dram/ddr2.c@187">Patch Set #1, Line 187:</a> <code style="font-family:monospace,monospace"> case 0:</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">In my version of the spec this is 0x80.</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21457/1/src/device/dram/ddr2.c@189">Patch Set #1, Line 189:</a> <code style="font-family:monospace,monospace">       case 1:</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">0x81</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21457/1/src/device/dram/ddr2.c@191">Patch Set #1, Line 191:</a> <code style="font-family:monospace,monospace">  case 2:</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">...</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/21457">change 21457</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21457"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I6a698ec9c15a2611a34c5965edf93638553775f0 </div>
<div style="display:none"> Gerrit-Change-Number: 21457 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 08 Sep 2017 22:07:48 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>