[coreboot-gerrit] Change in coreboot[master]: console/flashconsole: Enable support for postcar

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/21959 )

Change subject: console/flashconsole: Enable support for postcar
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/21959/2/src/drivers/spi/Makefile.inc
File src/drivers/spi/Makefile.inc:

https://review.coreboot.org/#/c/21959/2/src/drivers/spi/Makefile.inc@104
PS2, Line 104: CONFIG_BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY
Shouldn't this be CONFIG_BOOT_DEVICE_SPI_FLASH_RW_NOMMAP?


https://review.coreboot.org/#/c/21959/2/src/soc/intel/common/block/gspi/Makefile.inc
File src/soc/intel/common/block/gspi/Makefile.inc:

https://review.coreboot.org/#/c/21959/2/src/soc/intel/common/block/gspi/Makefile.inc@5
PS2, Line 5: gspi.c
Why is gspi being added for fast_spi i.e. spi flash access?



-- 
To view, visit https://review.coreboot.org/21959
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46d720a9d1fe18a95c9407d08dae1eb70ae6720e
Gerrit-Change-Number: 21959
Gerrit-PatchSet: 2
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 11 Oct 2017 23:13:20 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171011/95c54d75/attachment.html>