<p>Furquan Shaikh <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/21959">View Change</a></p><p>Patch set 2:</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/21959/2/src/drivers/spi/Makefile.inc">File src/drivers/spi/Makefile.inc:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21959/2/src/drivers/spi/Makefile.inc@104">Patch Set #2, Line 104:</a> <code style="font-family:monospace,monospace">CONFIG_BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Shouldn't this be CONFIG_BOOT_DEVICE_SPI_FLASH_RW_NOMMAP?</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/21959/2/src/soc/intel/common/block/gspi/Makefile.inc">File src/soc/intel/common/block/gspi/Makefile.inc:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21959/2/src/soc/intel/common/block/gspi/Makefile.inc@5">Patch Set #2, Line 5:</a> <code style="font-family:monospace,monospace">gspi.c</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why is gspi being added for fast_spi i.e. spi flash access?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/21959">change 21959</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21959"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I46d720a9d1fe18a95c9407d08dae1eb70ae6720e </div>
<div style="display:none"> Gerrit-Change-Number: 21959 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Youness Alaoui <snifikino@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 11 Oct 2017 23:13:20 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>