[coreboot-gerrit] Change in coreboot[master]: skylake/me: Add debug output of HFST registers

[Youness Alaoui (Code Review)]

Youness Alaoui has uploaded this change for review. ( https://review.coreboot.org/21960


Change subject: skylake/me: Add debug output of HFST registers
......................................................................

skylake/me: Add debug output of HFST registers

The ME status is the interpretation of the status registers, but
having the actual status registers printed is important and it doesn't
hurt to show them.

Change-Id: I6ef3401b36fedfa8aed14f4a62bdbec3d8c6d446
Signed-off-by: Youness Alaoui <youness.alaoui at puri.sm>
---
M src/soc/intel/skylake/include/soc/me.h
M src/soc/intel/skylake/me.c
2 files changed, 14 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/21960/1

diff --git a/src/soc/intel/skylake/include/soc/me.h b/src/soc/intel/skylake/include/soc/me.h
index e88711d..b94e0ef 100644
--- a/src/soc/intel/skylake/include/soc/me.h
+++ b/src/soc/intel/skylake/include/soc/me.h
@@ -188,6 +188,8 @@
 	} __packed fields;
 };
 
+#define PCI_ME_HFSTS4			0x64
+#define PCI_ME_HFSTS5			0x68
 #define PCI_ME_HFSTS6			0x6c
 #define ME_HFS6_FPF_NOT_COMMITTED	0x0
 #define ME_HFS6_FPF_ERROR		0x2
diff --git a/src/soc/intel/skylake/me.c b/src/soc/intel/skylake/me.c
index 1a6dcdd..f4df831 100644
--- a/src/soc/intel/skylake/me.c
+++ b/src/soc/intel/skylake/me.c
@@ -232,6 +232,18 @@
 	hfs3.data = me_read_config32(PCI_ME_HFSTS3);
 	hfs6.data = me_read_config32(PCI_ME_HFSTS6);
 
+	printk(BIOS_DEBUG, "ME: Host Firmware Status Register 1 : 0x%08X\n",
+		hfs.data);
+	printk(BIOS_DEBUG, "ME: Host Firmware Status Register 2 : 0x%08X\n",
+		hfs2.data);
+	printk(BIOS_DEBUG, "ME: Host Firmware Status Register 3 : 0x%08X\n",
+		hfs3.data);
+	printk(BIOS_DEBUG, "ME: Host Firmware Status Register 4 : 0x%08X\n",
+		me_read_config32(PCI_ME_HFSTS4));
+	printk(BIOS_DEBUG, "ME: Host Firmware Status Register 5 : 0x%08X\n",
+		me_read_config32(PCI_ME_HFSTS5));
+	printk(BIOS_DEBUG, "ME: Host Firmware Status Register 6 : 0x%08X\n",
+		hfs6.data);
 	/* Check Current States */
 	printk(BIOS_DEBUG, "ME: FW Partition Table      : %s\n",
 	       hfs.fields.fpt_bad ? "BAD" : "OK");

-- 
To view, visit https://review.coreboot.org/21960
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ef3401b36fedfa8aed14f4a62bdbec3d8c6d446
Gerrit-Change-Number: 21960
Gerrit-PatchSet: 1
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171011/351217ab/attachment-0001.html>