<p>Youness Alaoui has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21960">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">skylake/me: Add debug output of HFST registers<br><br>The ME status is the interpretation of the status registers, but<br>having the actual status registers printed is important and it doesn't<br>hurt to show them.<br><br>Change-Id: I6ef3401b36fedfa8aed14f4a62bdbec3d8c6d446<br>Signed-off-by: Youness Alaoui <youness.alaoui@puri.sm><br>---<br>M src/soc/intel/skylake/include/soc/me.h<br>M src/soc/intel/skylake/me.c<br>2 files changed, 14 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/21960/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/skylake/include/soc/me.h b/src/soc/intel/skylake/include/soc/me.h<br>index e88711d..b94e0ef 100644<br>--- a/src/soc/intel/skylake/include/soc/me.h<br>+++ b/src/soc/intel/skylake/include/soc/me.h<br>@@ -188,6 +188,8 @@<br>    } __packed fields;<br> };<br> <br>+#define PCI_ME_HFSTS4                      0x64<br>+#define PCI_ME_HFSTS5                    0x68<br> #define PCI_ME_HFSTS6                    0x6c<br> #define ME_HFS6_FPF_NOT_COMMITTED        0x0<br> #define ME_HFS6_FPF_ERROR         0x2<br>diff --git a/src/soc/intel/skylake/me.c b/src/soc/intel/skylake/me.c<br>index 1a6dcdd..f4df831 100644<br>--- a/src/soc/intel/skylake/me.c<br>+++ b/src/soc/intel/skylake/me.c<br>@@ -232,6 +232,18 @@<br>    hfs3.data = me_read_config32(PCI_ME_HFSTS3);<br>  hfs6.data = me_read_config32(PCI_ME_HFSTS6);<br> <br>+      printk(BIOS_DEBUG, "ME: Host Firmware Status Register 1 : 0x%08X\n",<br>+               hfs.data);<br>+   printk(BIOS_DEBUG, "ME: Host Firmware Status Register 2 : 0x%08X\n",<br>+               hfs2.data);<br>+  printk(BIOS_DEBUG, "ME: Host Firmware Status Register 3 : 0x%08X\n",<br>+               hfs3.data);<br>+  printk(BIOS_DEBUG, "ME: Host Firmware Status Register 4 : 0x%08X\n",<br>+               me_read_config32(PCI_ME_HFSTS4));<br>+    printk(BIOS_DEBUG, "ME: Host Firmware Status Register 5 : 0x%08X\n",<br>+               me_read_config32(PCI_ME_HFSTS5));<br>+    printk(BIOS_DEBUG, "ME: Host Firmware Status Register 6 : 0x%08X\n",<br>+               hfs6.data);<br>   /* Check Current States */<br>    printk(BIOS_DEBUG, "ME: FW Partition Table      : %s\n",<br>           hfs.fields.fpt_bad ? "BAD" : "OK");<br></pre><p>To view, visit <a href="https://review.coreboot.org/21960">change 21960</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21960"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6ef3401b36fedfa8aed14f4a62bdbec3d8c6d446 </div>
<div style="display:none"> Gerrit-Change-Number: 21960 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Youness Alaoui <snifikino@gmail.com> </div>