[coreboot-gerrit] Change in coreboot[master]: cpu/x86/mp_init.c: Remove hard coded timeout in bsp_do_fligh...

[Anonymous Coward (Code Review)]

tomaszx.jozwiak at intel.com has posted comments on this change. ( https://review.coreboot.org/18931 )

Change subject: cpu/x86/mp_init.c: Remove hard coded timeout in bsp_do_flight_plan
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/18931/2/src/include/cpu/x86/mp.h
File src/include/cpu/x86/mp.h:

Line 32: #endif
> What are you trying to calculate? If you have > 8 cpus you need more time b
Ok, so may be the better solution is create a weak function, which will return default value = 100ms. In that case anyone can override this function and rise the timeout if there is a case (for any reason). What do you think?


-- 
To view, visit https://review.coreboot.org/18931
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0787009e8286b13bc76f763758e42aa6d6782d4
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: tomaszx.jozwiak at intel.com
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: tomaszx.jozwiak at intel.com
Gerrit-HasComments: Yes