[coreboot-gerrit] Change in coreboot[master]: cpu/x86/mp_init.c: Remove hard coded timeout in bsp_do_fligh...

[Anonymous Coward (Code Review)]

Anonymous Coward #1001583 has posted comments on this change. ( https://review.coreboot.org/18931 )

Change subject: cpu/x86/mp_init.c: Remove hard coded timeout in bsp_do_flight_plan
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/18931/1/src/include/cpu/x86/mp.h
File src/include/cpu/x86/mp.h:

Line 29: #define MP_TIMEOUT_STEP_US 100
> Typically you would just pick a timeout large enough, when it is unlikely w
Sorry I didn't see your comment before my second commit.There is no possible to do that for all baud rate, I know. At least I would like to rise it, to don't have a fail from MP init during debug for more than 8 cores.


-- 
To view, visit https://review.coreboot.org/18931
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0787009e8286b13bc76f763758e42aa6d6782d4
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Anonymous Coward #1001583
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Anonymous Coward #1001583
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes