[coreboot-gerrit] Change in coreboot[master]: cpu/x86/mp_init.c: Remove hard coded timeout in bsp_do_fligh...
Anonymous Coward (Code Review)
gerrit at coreboot.org
Tue Mar 21 23:34:06 CET 2017
tomaszx.jozwiak at intel.com has posted comments on this change. ( https://review.coreboot.org/18931 )
Change subject: cpu/x86/mp_init.c: Remove hard coded timeout in bsp_do_flight_plan
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/18931/2/src/cpu/x86/mp_init.c
File src/cpu/x86/mp_init.c:
Line 548: printk(BIOS_ERR, "MP record %d timeout.\n", i);
> Yes. We don't drop locks nor plan for CPUs going off into the weeds current
When we have timeout here post_mp_init() will not be called. That's the reason of my fix.
--
To view, visit https://review.coreboot.org/18931
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0787009e8286b13bc76f763758e42aa6d6782d4
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: tomaszx.jozwiak at intel.com
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: tomaszx.jozwiak at intel.com
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list