[coreboot-gerrit] New patch to review for coreboot: src/include: Move constants to the right hand side

Lee Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Wed Mar 8 20:06:30 CET 2017


Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18682

-gerrit

commit 726e11a35484ea3b84613fd89b817931f0b7e04e
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Wed Mar 8 10:01:34 2017 -0800

    src/include: Move constants to the right hand side
    
    Fix the following warning detected by checkpatch.pl:
    
    WARNING: Comparisons should place the constant on the right side of the test
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: Id790e0034ea5c926fcaef95486319d6c0c936f28
    Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
---
 src/include/console/early_print.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/include/console/early_print.h b/src/include/console/early_print.h
index 173b6fe..cde501a 100644
--- a/src/include/console/early_print.h
+++ b/src/include/console/early_print.h
@@ -25,7 +25,7 @@
 /* While in romstage, console loglevel is built-time constant.
  * With ROMCC we inline this test with help from preprocessor.
  */
-#define console_log_level(msg_level) (CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= msg_level)
+#define console_log_level(msg_level) (msg_level <= CONFIG_DEFAULT_CONSOLE_LOGLEVEL)
 
 #define CALL_CONSOLE_TX(loglevel, tx_func, x) \
 	do {						\



More information about the coreboot-gerrit mailing list