[coreboot-gerrit] Patch set updated for coreboot: src/include: Remove space between function name and parameters

Lee Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Wed Mar 8 20:06:29 CET 2017


Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18660

-gerrit

commit 41974e564a3d3e2611bd500e90c3a2a82bc99027
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Tue Mar 7 16:10:21 2017 -0800

    src/include: Remove space between function name and parameters
    
    Fix the following warning detected by checkpatch.pl:
    
    WARNING: Unnecessary space before function pointer arguments
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: I2b56af20d5f74cc2625d3cb357fbb137bd440af0
    Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
---
 src/include/device/pci.h   | 12 ++++++------
 src/include/device/smbus.h | 20 ++++++++++----------
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/src/include/device/pci.h b/src/include/device/pci.h
index a8e7f8b..952f6e3 100644
--- a/src/include/device/pci.h
+++ b/src/include/device/pci.h
@@ -39,12 +39,12 @@ struct pci_operations {
 
 /* Common pci bus operations */
 struct pci_bus_operations {
-	uint8_t (*read8)   (struct bus *pbus, int bus, int devfn, int where);
-	uint16_t (*read16) (struct bus *pbus, int bus, int devfn, int where);
-	uint32_t (*read32) (struct bus *pbus, int bus, int devfn, int where);
-	void (*write8)  (struct bus *pbus, int bus, int devfn, int where, uint8_t val);
-	void (*write16) (struct bus *pbus, int bus, int devfn, int where, uint16_t val);
-	void (*write32) (struct bus *pbus, int bus, int devfn, int where, uint32_t val);
+	uint8_t   (*read8)(struct bus *pbus, int bus, int devfn, int where);
+	uint16_t (*read16)(struct bus *pbus, int bus, int devfn, int where);
+	uint32_t (*read32)(struct bus *pbus, int bus, int devfn, int where);
+	void     (*write8)(struct bus *pbus, int bus, int devfn, int where, uint8_t val);
+	void    (*write16)(struct bus *pbus, int bus, int devfn, int where, uint16_t val);
+	void    (*write32)(struct bus *pbus, int bus, int devfn, int where, uint32_t val);
 };
 
 struct pci_driver {
diff --git a/src/include/device/smbus.h b/src/include/device/smbus.h
index ccbd694..820dac3 100644
--- a/src/include/device/smbus.h
+++ b/src/include/device/smbus.h
@@ -8,17 +8,17 @@
 
 /* Common SMBus bus operations */
 struct smbus_bus_operations {
-	int (*quick_read)  (device_t dev);
-	int (*quick_write) (device_t dev);
-	int (*recv_byte)   (device_t dev);
-	int (*send_byte)   (device_t dev, u8 value);
-	int (*read_byte)   (device_t dev, u8 addr);
-	int (*write_byte)  (device_t dev, u8 addr, u8 value);
-	int (*read_word)   (device_t dev, u8 addr);
-	int (*write_word)  (device_t dev, u8 addr, u16 value);
+	int   (*quick_read)(device_t dev);
+	int  (*quick_write)(device_t dev);
+	int    (*recv_byte)(device_t dev);
+	int    (*send_byte)(device_t dev, u8 value);
+	int    (*read_byte)(device_t dev, u8 addr);
+	int   (*write_byte)(device_t dev, u8 addr, u8 value);
+	int    (*read_word)(device_t dev, u8 addr);
+	int   (*write_word)(device_t dev, u8 addr, u16 value);
 	int (*process_call)(device_t dev, u8 cmd, u16 data);
-	int (*block_read)  (device_t dev, u8 cmd, u8 bytes, u8 *buffer);
-	int (*block_write) (device_t dev, u8 cmd, u8 bytes, const u8 *buffer);
+	int   (*block_read)(device_t dev, u8 cmd, u8 bytes, u8 *buffer);
+	int  (*block_write)(device_t dev, u8 cmd, u8 bytes, const u8 *buffer);
 };
 
 static inline const struct smbus_bus_operations *ops_smbus_bus(struct bus *bus)



More information about the coreboot-gerrit mailing list