[coreboot-gerrit] Change in coreboot[master]: Allow to enable MULTIPLE_VGA_ADAPTERS without editing Kconfig

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/20638 )

Change subject: Allow to enable MULTIPLE_VGA_ADAPTERS without editing Kconfig
......................................................................


Patch Set 4:

(1 comment)

Thank you for reviewing this option. Maybe it is indeed useless (and even harmful) for discrete GPU support, in which case it should be removed

https://review.coreboot.org/#/c/20638/4//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/20638/4//COMMIT_MSG@12
PS4, Line 12: could
> How? The guarded code limits the selected links to those that
Currently, enabling this option doesn't make my discrete GPU working... but maybe there is a bug that I can't see, and if someone more knowledgeable than me will fix this bug - my discrete GPU could become working. To attract more attention to this option I hoped to make it possible to enable it from menuconfig

But if you are sure that enabling this option is actually preventing the discrete GPUs from being able to work, then this option with misleading name should be removed from coreboot - together with its' guarded code



-- 
To view, visit https://review.coreboot.org/20638
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade58d3c373e0bc30d4642d9417c4e5224249136
Gerrit-Change-Number: 20638
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Banon <mikebdp2 at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Mike Banon <mikebdp2 at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 19 Jul 2017 08:26:03 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170719/74732795/attachment.html>