[coreboot-gerrit] Change in coreboot[master]: Allow to enable MULTIPLE_VGA_ADAPTERS without editing Kconfig

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/20638 )

Change subject: Allow to enable MULTIPLE_VGA_ADAPTERS without editing Kconfig
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

I think we can drop the option and the code it's guarding. Can we get
that tested? i.e. compare the "VGA: %s (aka node %d) link %d has VGA
device\n" lines in logs of two runs with this option set/unset.

Hmmm, maybe check both with ONBOARD_VGA_IS_PRIMARY set/unset to be
sure.

https://review.coreboot.org/#/c/20638/4//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/20638/4//COMMIT_MSG@12
PS4, Line 12: could
How? The guarded code limits the selected links to those that
have PCI_BRIDGE_CTL_VGA set and lead to the primary VGA device.

Now here is the weird thing: PCI_BRIDGE_CTL_VGA is only set
for bridges that lead to the primary VGA device by definition.

There is either a huge bug hiding somewhere or this option is a
no-op. Can you confirm that it changes any behaviour at all?
Even your commit message sounds like it doesn't.



-- 
To view, visit https://review.coreboot.org/20638
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade58d3c373e0bc30d4642d9417c4e5224249136
Gerrit-Change-Number: 20638
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Banon <mikebdp2 at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Mike Banon <mikebdp2 at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 19 Jul 2017 08:00:27 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170719/515db401/attachment.html>