[coreboot-gerrit] Change in coreboot[master]: Allow to enable MULTIPLE_VGA_ADAPTERS without editing Kconfig

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/20638 )

Change subject: Allow to enable MULTIPLE_VGA_ADAPTERS without editing Kconfig
......................................................................


Patch Set 4:

(1 comment)

> Thank you for reviewing this option. Maybe it is indeed useless
> (and even harmful) for discrete GPU support, in which case it
> should be removed

I doubt it's harmful. Please check logs for the mentioned lines with
and without this option and ONBOARD_VGA_IS_PRIMARY enabled (4 logs in
total). If you can confirm that MULTIPLE_VGA_ATAPTERS doesn't make a
difference, we can remove it and prevent further confusion.

https://review.coreboot.org/#/c/20638/4//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/20638/4//COMMIT_MSG@12
PS4, Line 12: could
> Currently, enabling this option doesn't make my discrete GPU working... but
The option shouldn't prevent anything. I just doubt that it does
something at all.

Regarding your original problem, please report that to the
mailing list or at ticket.coreboot.org. Elaborate what exactly
is not working (e.g. preboot gfx?, Linux gfx?, what has Linux
to say about the discrete GPU? does it find the AtomBIOS at
all?).



-- 
To view, visit https://review.coreboot.org/20638
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade58d3c373e0bc30d4642d9417c4e5224249136
Gerrit-Change-Number: 20638
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Banon <mikebdp2 at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Mike Banon <mikebdp2 at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 19 Jul 2017 09:22:47 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170719/19e6cf37/attachment.html>