[coreboot-gerrit] Change in coreboot[master]: security/crypto: Add crypto primitives for hashing data

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/22872 )

Change subject: security/crypto: Add crypto primitives for hashing data
......................................................................


Patch Set 5:

(5 comments)

https://review.coreboot.org/#/c/22872/5/.checkpatch.conf
File .checkpatch.conf:

https://review.coreboot.org/#/c/22872/5/.checkpatch.conf@31
PS5, Line 31: --exclude src/security/crypto/hash
Add a comment:

 # Exclude hashing library


https://review.coreboot.org/#/c/22872/5/src/security/crypto/Kconfig
File src/security/crypto/Kconfig:

https://review.coreboot.org/#/c/22872/5/src/security/crypto/Kconfig@3
PS5, Line 3: ## Copyright (C) 2017 Philipp Deppenwiese, Facebook, Inc.
Maybe:

 Copyright (C) 2017 Facebook, Inc.
 (Written by Philipp Deppenwiese <zaolin at das-labor.org> for Facebook, Inc.)

Up to you.


https://review.coreboot.org/#/c/22872/5/src/security/crypto/Kconfig@15
PS5, Line 15: menu "Cryptographic Primitives"
remove if prompt is removed.


https://review.coreboot.org/#/c/22872/5/src/security/crypto/Kconfig@18
PS5, Line 18: "Enable hashing primitives"
Leave out the prompt - I'd think this would be selected by some other feature that uses it.  By itself it doesn't do anything, so probably shouldn't be user facing.


https://review.coreboot.org/#/c/22872/5/src/security/crypto/Kconfig@23
PS5, Line 23: 
            : 	  If unsure, say N.
remove if prompt is removed.



-- 
To view, visit https://review.coreboot.org/22872
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I807084ebfffdc159fe95c45b4e5f0820bbfee5e1
Gerrit-Change-Number: 22872
Gerrit-PatchSet: 5
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 14 Dec 2017 19:23:28 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171214/1db85d01/attachment.html>