<p>Martin Roth <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/22872">View Change</a></p><p>Patch set 5:</p><p>(5 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/22872/5/.checkpatch.conf">File .checkpatch.conf:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22872/5/.checkpatch.conf@31">Patch Set #5, Line 31:</a> <code style="font-family:monospace,monospace">--exclude src/security/crypto/hash</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add a comment:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> # Exclude hashing library</pre></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/22872/5/src/security/crypto/Kconfig">File src/security/crypto/Kconfig:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22872/5/src/security/crypto/Kconfig@3">Patch Set #5, Line 3:</a> <code style="font-family:monospace,monospace">## Copyright (C) 2017 Philipp Deppenwiese, Facebook, Inc.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Maybe:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> Copyright (C) 2017 Facebook, Inc.<br> (Written by Philipp Deppenwiese <zaolin@das-labor.org> for Facebook, Inc.)</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Up to you.</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22872/5/src/security/crypto/Kconfig@15">Patch Set #5, Line 15:</a> <code style="font-family:monospace,monospace">menu "Cryptographic Primitives"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">remove if prompt is removed.</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22872/5/src/security/crypto/Kconfig@18">Patch Set #5, Line 18:</a> <code style="font-family:monospace,monospace">"Enable hashing primitives"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Leave out the prompt - I'd think this would be selected by some other feature that uses it.  By itself it doesn't do anything, so probably shouldn't be user facing.</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22872/5/src/security/crypto/Kconfig@23">Patch Set #5, Line 23:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><br>       If unsure, say N.<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">remove if prompt is removed.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22872">change 22872</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22872"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I807084ebfffdc159fe95c45b4e5f0820bbfee5e1 </div>
<div style="display:none"> Gerrit-Change-Number: 22872 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 14 Dec 2017 19:23:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>