[coreboot-gerrit] Change in coreboot[master]: google/chromeec: Add support for I2C and SPI devices
Duncan Laurie (Code Review)
gerrit at coreboot.org
Wed Apr 26 23:39:12 CEST 2017
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/19464 )
Change subject: google/chromeec: Add support for I2C and SPI devices
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/19464/1/src/ec/google/chromeec/acpi/cros_ec.asl
File src/ec/google/chromeec/acpi/cros_ec.asl:
Line 34: Name (_HID, "GOOG0008")
> Ahh. OK. But this device shouldn't be under the LPC block then? So maybe th
Hm I didn't see that patch upstreamed yet and I didn't realize this would be exposed as a different slave address. I think this does need reworked, I'll talk to wnhuang and figure out what the intended interaction is.
--
To view, visit https://review.coreboot.org/19464
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedb2beb5ab96f1632855ac2ca344be68cc892d45
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list